Jing Xie (talk) 23:43, 14 May 2020 (UTC)
Published Properties
Ftuffner (talk) 16:39, 22 May 2020 (UTC)
- Updated `sync_check_object` and `controlled_generation_unit` to not be strings and not have "name" in the title (GLD can handle the linking, why do it manually?)
Jing Xie (talk) 19:53, 22 May 2020 (UTC): Good fix. I overlooked here.
- Does anyone have any preferences on if normal inverter objects should be used? Why just diesel_dg and inverter_dyn?
Jing Xie (talk) 19:53, 22 May 2020 (UTC): I discussed the controlled generation unit with Wei. Wei prefers to consider only DG and inverter_dyn.
- It's not entirely clear how metrics_period vs monitoring_period are used. Are they both being used?
Jing Xie (talk) 19:53, 22 May 2020 (UTC): Yes, both of these settings are used. I modified their variable names in this morning, but did not get a chance to change the pseudocode accordingly. It will be updated soon.
- Since this came up with the sync_check object, does there need to be a separate metric for angle difference to determine when this operates in "mode B"?
Jing Xie (talk) 19:53, 22 May 2020 (UTC): I think we may not need to, while we can discuss further.
Methodology
Ftuffner (talk) 16:39, 22 May 2020 (UTC)
- When you populate the PI controller pseudocode sections, also be sure to indicate (via pseudocode) how they are being used - basically an overall pseudocode showing where your other "metrics check" functions are being used.
Validation
Ftuffner (talk) 16:39, 22 May 2020 (UTC)
- There's an explicit field for sync_check in the published properties. Why does the sync_ctrl need to be parented to it?
Jing Xie (talk) 19:53, 22 May 2020 (UTC): My initial design was the sync_check object specified as a parent of the sync_ctrl. I changed to two object properties later, but forgot to update the description in the validation section.